Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fixing muilt-arch image builds #301

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vamage
Copy link

@vamage vamage commented Oct 9, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:
Fixing the docker file for multi-arch builds as it currently only works for native arch. Currently the build process only copies the ./bin/iscsiplugin to all built images instead of ./bin/iscsiplugin-$ARCH causing exec /iscsiplugin: exec format error because:
iscsiplugin: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=69pHWuyHaqIJGzRCAB4A/dC8bXCTAacAAIfzDgxdr/QKo4BKFZMVWEunvrdxYZ/ZVyRnJRB4H_MT4it7Iy8, with debug_info, not stripped

Which issue(s) this PR fixes:
Fixes : #217

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
None

Fixing `exec /iscsiplugin: exec format error` on non-amd64 linux images

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Oct 9, 2024
Copy link

linux-foundation-easycla bot commented Oct 9, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vamage
Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 9, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @vamage!

It looks like this is your first PR to kubernetes-csi/csi-driver-iscsi 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-driver-iscsi has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 9, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @vamage. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 9, 2024
@vamage
Copy link
Author

vamage commented Oct 11, 2024

oops looks like i misspelled iscsi as isci 🤦

Dockerfile Outdated
@@ -18,6 +18,7 @@ RUN apt update && apt upgrade -y && apt-mark unhold libcap2
RUN clean-install util-linux e2fsprogs mount ca-certificates udev xfsprogs btrfs-progs open-iscsi

CMD service iscsid start
COPY ./bin/iscsiplugin /iscsiplugin
ARG binary="./bin/iscsiplugin"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use following path?

ARG binary=./bin/${ARCH}/iscsiplugin
COPY ${binary} /iscsiplugin

https://github.com/kubernetes-csi/csi-driver-nfs/blob/master/Dockerfile#L18

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let me look this afternoon. I think there was some reason i saw in the makefile.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 15, 2024
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 16, 2024
@vamage
Copy link
Author

vamage commented Oct 16, 2024

didn't realize i couldn't touch release-tools. I'll need to rethink the approach. Let me mark this as WIP.

@vamage vamage changed the title Fixing muilt-arch image builds WIP: Fixing muilt-arch image builds Oct 16, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 31, 2024
@k8s-ci-robot
Copy link
Contributor

@vamage: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-csi-csi-driver-iscsi 7003b9b link true /test pull-kubernetes-csi-csi-driver-iscsi

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exec /iscsiplugin: exec format error on Raspberry Pi 4
3 participants