-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Fixing muilt-arch image builds #301
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vamage The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @vamage! |
Hi @vamage. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
d2e0e31
to
9aff3a8
Compare
oops looks like i misspelled iscsi as isci 🤦 |
Dockerfile
Outdated
@@ -18,6 +18,7 @@ RUN apt update && apt upgrade -y && apt-mark unhold libcap2 | |||
RUN clean-install util-linux e2fsprogs mount ca-certificates udev xfsprogs btrfs-progs open-iscsi | |||
|
|||
CMD service iscsid start | |||
COPY ./bin/iscsiplugin /iscsiplugin | |||
ARG binary="./bin/iscsiplugin" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not use following path?
ARG binary=./bin/${ARCH}/iscsiplugin
COPY ${binary} /iscsiplugin
https://github.com/kubernetes-csi/csi-driver-nfs/blob/master/Dockerfile#L18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, let me look this afternoon. I think there was some reason i saw in the makefile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
didn't realize i couldn't touch |
19f111f
to
7003b9b
Compare
@vamage: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixing the docker file for multi-arch builds as it currently only works for native arch. Currently the build process only copies the
./bin/iscsiplugin
to all built images instead of./bin/iscsiplugin-$ARCH
causingexec /iscsiplugin: exec format error
because:iscsiplugin: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=69pHWuyHaqIJGzRCAB4A/dC8bXCTAacAAIfzDgxdr/QKo4BKFZMVWEunvrdxYZ/ZVyRnJRB4H_MT4it7Iy8, with debug_info, not stripped
Which issue(s) this PR fixes:
Fixes : #217
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
None