Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI to use 1.32 eks and kops clusters #2323

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Update CI to use 1.32 eks and kops clusters #2323

merged 1 commit into from
Feb 5, 2025

Conversation

ElijahQuinones
Copy link
Member

What type of PR is this?

/kind cleanup

What is this PR about? / Why do we need it?

This PR updates our CI to use k8s 1.32 when creating clusters using kops and eksctl

How was this change tested?

CI and running make cluster/create with change to verify 1.32 cluster is created

Does this PR introduce a user-facing change?

NONE

/hold

holding until local testing is done

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 30, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 30, 2025
@ElijahQuinones ElijahQuinones added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2025
@github-actions GitHub Actions
Copy link

Code Coverage Diff

This PR does not change the code coverage

@ElijahQuinones
Copy link
Member Author

ElijahQuinones commented Jan 30, 2025 •
edited
Loading

When running locally run in to Error: cannot determine hash for "https://artifacts.k8s.io/binaries/kops/1.32.0-beta.1/linux/amd64/nodeup" (have you specified a valid file location?) will give time for this to be resolved as this beta version of kops has only come out 11 hours ago and looking into it appears the binary is not yet available at that url.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 30, 2025
@AndrewSirenko
Copy link
Contributor

FYI eksctl release v0.201.0 made metrics-server a default add-on (source)

This means that eks tests are likely failing due to a conflict between our CI scripts attempting to install metrics-server, and eksctl already doing it.

We'll either have to edit run.sh to not install metrics-server for eksctl clusters (or, less ideal, override eksctl to not install metrics-server)

@ElijahQuinones
Copy link
Member Author

/retest

looks like https://artifacts.k8s.io/binaries/kops/1.32.0-beta.1/linux/amd64/nodeup is available now

@ElijahQuinones ElijahQuinones removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 3, 2025
@ElijahQuinones
Copy link
Member Author

Tested locally and am able to successfully make a 1.32 cluster with make/cluster

❯ kubectl version
Client Version: v1.32.1
Kustomize Version: v5.5.0
Server Version: v1.32.1

Additionally CI is now passing unholding CR

AndrewSirenko
AndrewSirenko approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@AndrewSirenko AndrewSirenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2025
torredil
torredil approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2025
@k8s-ci-robot k8s-ci-robot merged commit f419052 into kubernetes-sigs:master Feb 5, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewSirenko AndrewSirenko AndrewSirenko approved these changes

@torredil torredil torredil approved these changes

Assignees

@AndrewSirenko AndrewSirenko

@torredil torredil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ElijahQuinones @AndrewSirenko @k8s-ci-robot @torredil