Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade python distro and create symlink to stunnel5 #1569

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

dankova22
Copy link
Contributor

Upgrade python distros. Add symlink for stunnel5 -> stunnel to keep backwards compatibility for upgrade process where binary is expected at /usr/bin/stunnel5.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 10, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 10, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @dankova22. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 10, 2025
@andrewjamesbrown
Copy link
Contributor

@dankova22 is this PR/fix somehow related to this?

@andrewjamesbrown
Copy link
Contributor

Upgrade python distros. Add symlink for stunnel5 -> stunnel to keep backwards compatibility for upgrade process where binary is expected at /usr/bin/stunnel5.

For my own info, what upgrade processes depend on /usr/bin/stunnel5 versus /usr/bin/stunnel?

@andrewjamesbrown
Copy link
Contributor

It looks like the efs-utils code should be using this function to find the appropriate stunnel binary (which is different on AL2)

@mskanth972
Copy link
Contributor

mskanth972 commented Jan 13, 2025

@andrewjamesbrown, when there are existing mounts using Stunnel5 binary and when we upgrade to EFS CSI Driver version which is using Stunnel, the mounts are breaking due to binary configuration change and pods are unable to read/write to the existing application. We have tested this and able to reproduce this scenario, so we are creating symlink.

@mskanth972
Copy link
Contributor

mskanth972 commented Jan 13, 2025

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 13, 2025
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 13, 2025
@mskanth972
Copy link
Contributor

It looks like the efs-utils code should be using this function to find the appropriate stunnel binary (which is different on AL2)

Looks like driver mentions stunnel explicitly in DockerFile, Unless we create a symlink (ln -s /usr/bin/stunnel /usr/bin/stunnel5), the mount process will fail.

@andrewjamesbrown
Copy link
Contributor

@mskanth972 who knew that upgrading from AL2 to AL2023 would be so challenging :-)

@dankova22
Copy link
Contributor Author

/retest

1 similar comment
@dankova22
Copy link
Contributor Author

/retest

@dankova22
Copy link
Contributor Author

/test pull-aws-efs-csi-driver-external-test-eks
/test pull-aws-efs-csi-driver-e2e

@dankova22
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 16, 2025
@mskanth972
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dankova22, mskanth972

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2025
@k8s-ci-robot k8s-ci-robot merged commit c3b17aa into kubernetes-sigs:master Jan 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants