Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TCP support in dataplane #86

Merged
merged 5 commits into from
May 3, 2023
Merged

TCP support in dataplane #86

merged 5 commits into from
May 3, 2023

Conversation

shaneutt
Copy link
Member

@shaneutt shaneutt commented May 2, 2023 •
edited
Loading

This adds TCP support to the dataplane and includes integration tests to verify TCPRoute functionality.

Resolves #15

@shaneutt shaneutt changed the title shaneutt/dataplane tcp support TCP support in dataplane May 2, 2023
@shaneutt shaneutt added this to the v0.2.0 - TCPRoute Support milestone May 2, 2023
@shaneutt shaneutt added feature New feature or request area/dataplane labels May 2, 2023
@shaneutt shaneutt requested review from astoycos and mlavacca May 2, 2023 23:01
@shaneutt shaneutt marked this pull request as ready for review May 2, 2023 23:21
@shaneutt shaneutt enabled auto-merge (rebase) May 2, 2023 23:22
@shaneutt shaneutt disabled auto-merge May 3, 2023 02:14
@shaneutt shaneutt enabled auto-merge (rebase) May 3, 2023 02:14
astoycos
astoycos approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@astoycos astoycos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for this @shaneutt!

I think the only thing I would add here is let's make an issue to also investigate the tcp_hdr.check = 0 question to determine exactly how that's working.

auto-merge was automatically disabled May 3, 2023 14:59

Base branch requires signed commits

@shaneutt
Copy link
Member Author

shaneutt commented May 3, 2023

I think the only thing I would add here is let's make an issue to also investigate the tcp_hdr.check = 0 question to determine exactly how that's working.

Sounds good, there's an existing issue for getting the checksums questions figured out and consistently handling them which I think should cover us as a follow-up: #25

@shaneutt shaneutt merged commit cfde694 into kubernetes-sigs:main May 3, 2023
@shaneutt shaneutt deleted the shaneutt/dataplane-tcp-support branch May 3, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astoycos astoycos astoycos approved these changes

@mlavacca mlavacca Awaiting requested review from mlavacca

Assignees
No one assigned
Labels
area/dataplane feature New feature or request
Projects
None yet
Milestone
v0.2.0 - TCPRoute Support
Development

Successfully merging this pull request may close these issues.

TCP Support (data-plane)
2 participants
@shaneutt @astoycos