Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ WIP: Introduce AWSMachine and AWSCluster feature gates #5284

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

✨ WIP: Introduce AWSMachine and AWSCluster feature gates #5284

wants to merge 1 commit into from

Conversation

mzazrivec
Copy link
Contributor

@mzazrivec mzazrivec commented Jan 15, 2025 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 15, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nrb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-priority needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 15, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @mzazrivec. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 15, 2025
@mzazrivec mzazrivec changed the title ✨ Introduce AWSMachine and AWSCluster feature gates ✨ WIP: Introduce AWSMachine and AWSCluster feature gates Jan 15, 2025
fiunchinho
fiunchinho reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@fiunchinho fiunchinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add tests?

serngawy
serngawy reviewed Jan 20, 2025
View reviewed changes
feature/feature.go Outdated
@@ -108,4 +116,6 @@ var defaultCAPAFeatureGates = map[featuregate.Feature]featuregate.FeatureSpec{
AlternativeGCStrategy: {Default: false, PreRelease: featuregate.Alpha},
TagUnmanagedNetworkResources: {Default: true, PreRelease: featuregate.Alpha},
ROSA: {Default: false, PreRelease: featuregate.Alpha},
AWSMachine: {Default: true, PreRelease: featuregate.Alpha},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe both feature gates should be beta not alpha

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@mzazrivec mzazrivec force-pushed the aws_self_managed_granularity_switches branch from bbe29d0 to 6dbdfb1 Compare January 29, 2025 10:52
@mzazrivec
Copy link
Contributor Author

Would it be possible to add tests?

While I understand the utility and usefulness of tests, creating tests for the feature gates would require changing main.go, maybe other files too (i.e. there are no tests for feature gates yet). Since this pull request implements the proposal from #5276 I really want to avoid any further changes here.

@serngawy
Copy link
Contributor

Would it be possible to add tests?

While I understand the utility and usefulness of tests, creating tests for the feature gates would require changing main.go, maybe other files too (i.e. there are no tests for feature gates yet). Since this pull request implements the proposal from #5276 I really want to avoid any further changes here.

You may update the e2e test to check for the feature-gate is enbaled/disabled similar to AlternativeGCStrategy test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serngawy serngawy serngawy left review comments

@fiunchinho fiunchinho fiunchinho left review comments

@damdo damdo Awaiting requested review from damdo

@luthermonson luthermonson Awaiting requested review from luthermonson

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mzazrivec @k8s-ci-robot @serngawy @fiunchinho