Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [release-2.5] fix: self hosted e2e test caused by disk pressure. #5298

Open
wants to merge 1 commit into
base: release-2.5
Choose a base branch
from
Open

🐛 [release-2.5] fix: self hosted e2e test caused by disk pressure. #5298

wants to merge 1 commit into from

Conversation

richardcase
Copy link
Member

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

The self hosted e2e was failing as the control plane node was encountering disk pressure. This caused CAPA to be evicted and the CAPA images on the original node where deleted to reclaim disk space. When CAPA moved back to the node the image couldn't be found.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

Change the self hosted e2e template to give more disk space

@richardcase richardcase requested a review from Copilot January 21, 2025 11:03
@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 21, 2025
@k8s-ci-robot k8s-ci-robot added needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 21, 2025
@richardcase richardcase changed the title fix: self hosted e2e test caused by disk pressure. [release-2.5] fix: self hosted e2e test caused by disk pressure. Jan 21, 2025
Copilot
Copilot AI reviewed Jan 21, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

...ithoutclusterclass/kustomize_sources/remote-management-cluster/patches/root-volume-size.yaml
template:
spec:
rootVolume:
size: 10
Copy link
Preview

Copilot AI Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unit for the root volume size is not specified. It should be clarified whether it is in GB, MB, or another unit.

Suggested change
size: 10
size: 10Gi

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@richardcase richardcase changed the title [release-2.5] fix: self hosted e2e test caused by disk pressure. 🐛 [release-2.5] fix: self hosted e2e test caused by disk pressure. Jan 21, 2025
@richardcase
Copy link
Member Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@richardcase: The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-aws-build

/test pull-cluster-api-provider-aws-build-docker

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@richardcase richardcase changed the title 🐛 [release-2.5] fix: self hosted e2e test caused by disk pressure. WIP: 🐛 [release-2.5] fix: self hosted e2e test caused by disk pressure. Jan 21, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 21, 2025
@richardcase
Copy link
Member Author

Will rebase this when the cherry picks of #5300 have merged.

@richardcase
fix: self hosted e2e test caused by disk pressure.
759e715 
The self hosted e2e was failing as the control plane node was
encountering disk pressure. This caused CAPA to be evicted and the CAPA
images on the original node where deleted to reclaim disk space. When
CAPA moved back to the node the image couldn't be found.

Signed-off-by: Richard Case <[email protected]>
@richardcase richardcase changed the title WIP: 🐛 [release-2.5] fix: self hosted e2e test caused by disk pressure. 🐛 [release-2.5] fix: self hosted e2e test caused by disk pressure. Jan 22, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 22, 2025
@AndiDog
Copy link
Contributor

AndiDog commented Jan 22, 2025

/lgtm
/approve

/hold

Feel free to unhold once this is ready (tests needed?).

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndiDog
Once this PR has been reviewed and has the lgtm label, please ask for approval from richardcase. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@richardcase
Copy link
Member Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2025
@damdo
Copy link
Member

damdo commented Jan 23, 2025

@AndiDog it looks like your approve didn't stick, maybe because you weren't an approver on release-2.5
@richardcase it might be worth you sticking that approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@cnmcavoy cnmcavoy Awaiting requested review from cnmcavoy

@damdo damdo Awaiting requested review from damdo

Assignees

@AndiDog AndiDog

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@richardcase @k8s-ci-robot @AndiDog @damdo