🌱 observability: split up grafana configmap to not exceed the size limits on reoccuring apply #11769
Conversation
k8s-ci-robot
added
area/devtools
k8s-ci-robot
added
the
size/M
| @@ -88,8 +88,39 @@ dashboardProviders: | |||
| options: | |||
| path: /var/lib/grafana/dashboards/default | |||
|
|
|||
| dashboardsConfigMaps: | |||
| default: grafana-dashboards | |||
| dashboardsConfigMaps: {} | |||
There was a problem hiding this comment.
Is there a way to just get rid of that annotation?
There was a problem hiding this comment.
@chrischdi ^^ (no rush, just not sure if you saw and now the conversation is outdated :))
There was a problem hiding this comment.
Ah I thought you meant this valuesfile entry.
Well, it uses KubectL apply (tilt) I'm not aware how we could do that as long as we're not using go
There was a problem hiding this comment.
Was hoping maybe we can tell tilt to deploy with replace or eg enable SSA for apply
There was a problem hiding this comment.
I don't see a way to do this. (lookedup the api docs for k8s_yaml and k8s_resource)
…ts on reoccuring apply
chrischdi
force-pushed
the
pr-obs-grafana-split-dashboard-configmap
branch
from
0ff2dc1 to
cc138ef
Compare
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: fbcded2796bcb324bc008387f58ab89436f53274
|
|
Thx! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
…
What this PR does / why we need it:
Often getting the following when using tilt and having grafana enabled:
This resolves that by splitting up the dashboards configmap and instead have a single configmap per dashboard.
This way, when re-applying, the
last-applied-configuration' annotationsfits in again.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
/area devtools