-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Concurrency acceleration updateNodeClaimHash #1740
base: main
Are you sure you want to change the base?
chore: Concurrency acceleration updateNodeClaimHash #1740
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: helen-frank The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b989aa8
to
d842b83
Compare
Pull Request Test Coverage Report for Build 11357490965Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand why this needs to change. How does this speed up performance? Also, is this not something you can do with workqueue.ParallelizeUntil?
Asynchronously to use I went and read the code for workqueue.ParallelizeUntil, and it's really better than what I was doing, thanks for the guidance! |
d842b83
to
07fa968
Compare
Signed-off-by: helen <[email protected]>
07fa968
to
d3e7315
Compare
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
Fixes #N/A
Description
Concurrency acceleration updateNodeClaimHash
How was this change tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.