Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix push node having qemu setup reliably #3823

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix push node having qemu setup reliably #3823

merged 1 commit into from
Jan 23, 2025

Conversation

BenTheElder
Copy link
Member

#3818 (comment)

I think this is fine to do repeatedly if not ideal.

I'm also hacking on an alternate script for v1.31+ to use upstream builds.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 13, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2024
@BenTheElder BenTheElder mentioned this pull request Dec 13, 2024
Merged
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 13, 2024
@BenTheElder BenTheElder changed the title [WIP] fix push node having qemu setup reliably fix push node having qemu setup reliably Dec 16, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2024
@BenTheElder
Copy link
Member Author

this is ~fine for now

@BenTheElder
Copy link
Member Author

cc @aojea @stmcginnis

@stmcginnis
Copy link
Contributor

Looks good!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2025
@BenTheElder
Copy link
Member Author

BenTheElder commented Jan 23, 2025 •
edited
Loading

/retest
pod scheduling timeout 🙄 [CI, not kind]

@BenTheElder
Copy link
Member Author

/retest

1 similar comment
@BenTheElder
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 78cdad2 into kubernetes-sigs:main Jan 23, 2025
30 checks passed
@BenTheElder BenTheElder deleted the fix-push-node branch January 23, 2025 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@stmcginnis stmcginnis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenTheElder @k8s-ci-robot @stmcginnis