drop iptables support #13
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
| // NewController returns a new *Controller. | ||
| func NewController(client clientset.Interface, | ||
| nft knftables.Interface, |
There was a problem hiding this comment.
Why pass nft into NewController but not nfq?
I feel like it makes more sense to have Controller create the knftables object itself. It knows what it needs; main doesn't.
There was a problem hiding this comment.
to mock it in the tests, so I can inject the Fake object
There was a problem hiding this comment.
also nfq needs to register the hooks that depend on the controller, it should be done during the controller construction
|
this is working on ci kubernetes/kubernetes#124484 |
no time for dealing with the old stuff , since we are moving on with nftables everywhere , having to maintain both is a lot of work for no much return
#12