Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added custom action for PR title checker #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added custom action for PR title checker #63

wants to merge 1 commit into from

Conversation

Ankit152
Copy link

Fixes: #62

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Ankit152
Once this PR has been reviewed and has the lgtm label, please assign mengqiy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 17, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @Ankit152!

It looks like this is your first PR to kubernetes-sigs/kubebuilder-release-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder-release-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 17, 2024
@Ankit152
Copy link
Author

@camilamacedo86 can you please have a look?

camilamacedo86
camilamacedo86 reviewed Sep 18, 2024
View reviewed changes
README.md
@@ -51,6 +51,10 @@ jobs:
uses: kubernetes-sigs/[email protected]
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above way will no longer any more.
It is deprecated. So, by adding new github action we need to update the note, ensure that we inform what is deprecated and provide the new solution.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay.
So, if I understand correctly, we need to remove the existing job yaml in the README and add the new one.

camilamacedo86
camilamacedo86 reviewed Sep 18, 2024
View reviewed changes
.github/actions/pr-title-checker.sh
@@ -0,0 +1,47 @@
#!/bin/bash

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to change the GitHub action used here to verify the PR title
to either test the PR title of this repo with the new solution so that we can ensure that works

camilamacedo86
camilamacedo86 reviewed Sep 18, 2024
View reviewed changes
.github/actions/pr-title-checker.sh
@@ -0,0 +1,47 @@
#!/bin/bash

# Copyright 2024 The Kubernetes Authors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By last we should either deprecated the Golang code with annotations/comments since we are replacing the old implementation with the shell script.

camilamacedo86
camilamacedo86 reviewed Sep 18, 2024
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot for your contribution 🥇
I added a few comments and suggestion please see wdyt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 left review comments

@mengqiy mengqiy Awaiting requested review from mengqiy

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a Custom action to provide the shell script to validate the PR titles
3 participants
@Ankit152 @k8s-ci-robot @camilamacedo86