Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rescaffolding docs incorrect note about parameters #4478

Open
Sijoma opened this issue Jan 9, 2025 · 3 comments
Open

Rescaffolding docs incorrect note about parameters #4478

Sijoma opened this issue Jan 9, 2025 · 3 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation.

Comments

@Sijoma
Copy link
Contributor

Sijoma commented Jan 9, 2025

What broke? What's expected?

The documentation for rescaffolding mentions two contradictory statements:

output-dir is the path to the directory where you want to generate the new project. Default is a subdirectory in the current working directory.

If neither input-dir nor output-dir are specified, the project will be regenerated in the current directory.

The note also mentions:

This approach facilitates comparison between your current local branch and the version stored upstream (e.g., GitHub main branch). This way, you can easily overlay your project’s code changes atop the new scaffold.

From the above defaults I expected the output-dir from the extra note was expecting something where I can easily diff the result with Git inside the same folders. Comparing with git is not really possible if its in a subfolder outputdir`.

Reproducing this issue

Run the kubebuilder alpha generate command and see that a output-dir is created.

KubeBuilder (CLI) Version

4.3.1

PROJECT version

3

Plugin versions

No response

Other versions

go 1.23.4

Extra Labels

/kind documentation

@Sijoma Sijoma added the kind/bug Categorizes issue or PR as related to a bug. label Jan 9, 2025
@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Jan 9, 2025
@camilamacedo86
Copy link
Member

Hi @Sijoma,

I think what raised confusion here: 'Default is a subdirectory in the current working directory.`.
However, please feel free to open a PR with any improvement/suggestion that you see fit for the documentation.
Then, we move from there.

Thank you for looking into that.

Sijoma added a commit to Sijoma/kubebuilder that referenced this issue Jan 9, 2025
- name the default explicitly

relates kubernetes-sigs#4478
@Sijoma
Copy link
Contributor Author

Sijoma commented Jan 9, 2025

I tried to improve it a little bit in this draft PR #4479 .

Maybe this helps.

@Sijoma
Copy link
Contributor Author

Sijoma commented Jan 9, 2025

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Development

No branches or pull requests

3 participants