network: add ipv6 only global option

[borislitv]

What type of PR is this?
/kind feature

What this PR does / why we need it:
Support ipv6 only clusters

Which issue(s) this PR fixes:
Fixes #5649

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add support for ipv6 only cluster via "enable_ipv6only_stack_networks"

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: borislitv / name: Boris (1f8b722)

[k8s-ci-robot]

Welcome @borislitv!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @borislitv. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[yankay]

/ok-to-test

[MrFreezeex]

Thanks for your contribution, the initiative looks great. I left a few comments on possible improvements to improve readability though.

[borislitv]

It work in my vagrant:

root@k8s-1:/home/vagrant# kubectl get nodes -o wide
NAME    STATUS   ROLES           AGE     VERSION   INTERNAL-IP                           EXTERNAL-IP   OS-IMAGE           KERNEL-VERSION     CONTAINER-RUNTIME
k8s-1   Ready    control-plane   9m5s    v1.32.0   fd3c:b398:698:756:5054:ff:fe49:e571   <none>        Ubuntu 24.04 LTS   6.8.0-31-generic   containerd://1.7.24
k8s-2   Ready    control-plane   8m50s   v1.32.0   fd3c:b398:698:756:5054:ff:fe7d:1cd1   <none>        Ubuntu 24.04 LTS   6.8.0-31-generic   containerd://1.7.24
k8s-3   Ready    <none>          7m52s   v1.32.0   fd3c:b398:698:756:5054:ff:feb8:8851   <none>        Ubuntu 24.04 LTS   6.8.0-31-generic   containerd://1.7.24

/retest

[borislitv]

@geneliu my test with kubeadm etcd but checked on my local vagrant with etcd without kubeadm.
@VannTen @MrFreezeex It seems like everything worked out

[MrFreezeex]

Thanks! It looks good to me, could you just clean up a bit your commits 🙏?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: borislitv, MrFreezeex, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [VannTen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[borislitv]

Thanks! It looks good to me, could you just clean up a bit your commits 🙏?

squashed

[MrFreezeex]

/lgtm

[VannTen]

@borislitv

This appears to have broken pre-commit ansible-lint, would you mind taking a look ?

roles/kubernetes/client/tasks/main.yml:68: jinja[invalid][/]: An unhandled exception occurred while templating 
'{{ {'clusters': [{'cluster': (cluster_infos | combine({'server': 'https://' + (external_apiserver_address | ansible.utils.ipwrap) 
+ ':' + (external_apiserver_port | string)})), 'name': cluster_name}]} }}'. Error was a <class 
'ansible.errors.AnsibleFilterError'>, original message: Unrecognized type <<class 
'ansible.template.native_helpers.AnsibleUndefined'>> for ipwrap filter <value>

[borislitv]

@borislitv

This appears to have broken pre-commit ansible-lint, would you mind taking a look ?

roles/kubernetes/client/tasks/main.yml:68: jinja[invalid][/]: An unhandled exception occurred while templating 
'{{ {'clusters': [{'cluster': (cluster_infos | combine({'server': 'https://' + (external_apiserver_address | ansible.utils.ipwrap) 
+ ':' + (external_apiserver_port | string)})), 'name': cluster_name}]} }}'. Error was a <class 
'ansible.errors.AnsibleFilterError'>, original message: Unrecognized type <<class 
'ansible.template.native_helpers.AnsibleUndefined'>> for ipwrap filter <value>

I'll see a couple of hours. and I'll make a new pr

[borislitv]

' + (external_apiserver_address | ansible.utils.ipwrap)

• ':' + (external_apiserver_port | string)})), 'name': cluster_name}]} }}'. Error was a <class
  'ansible.errors.AnsibleFilterError'>, original message: Unrecognized type <<class
  'ansible.template.native_helpers.AnsibleUndefined'>> for ipwrap filter

looks like a bug in ansible-lint ansible/ansible-lint#3136
which version does this play on?
unable to reproduce:(

[VannTen]

Hum, maybe this explains why this has been inconsistent... I had this in the pre-commit ci PR and then it disappeared... Don't worry then thanks for digging the related issue 👍

[VannTen]

I think I figured out the issue. ansible-lint apparently install collections when running (from galaxy.yml I guess ?). It passes without issue if the collections are not installed, (and installs them), but fails when there are already installed (I think by default they are in ~/.ansible/collections)

[borislitv]

I think I figured out the issue. ansible-lint apparently install collections when running (from galaxy.yml I guess ?). It passes without issue if the collections are not installed, (and installs them), but fails when there are already installed (I think by default they are in ~/.ansible/collections)

looked again at the template, unfortunately it will not work otherwise, because variable is needed without brackets in https://github.com/borislitv/kubespray/blob/1f8b722d4ccdef4d9049ba4855de5992a22704ea/roles/kubernetes/client/tasks/main.yml#L50

[VannTen]

I didn't dig in the template itself, but it does not look like an actual problem, more like a bug in ansible-lint (similar but not identical to the one above). I'll open an issue over there to see what can be done about that 🤔

[ant31]

This PR is not working on ipv4 only systems

[ant31]

Also the configuration should be done once via set fact or something other mechanism than going down the road of a condition in every single variable, it won't be maintainable long-term to have a switch in every one of them.

for example so instead of doing

etcd_address: access_ipv6 if ipv6 else access_ip

I suggest to do:

access_ip: access_ipv6 if ipv6 else access_ip

That way the change is isolated in one location and propagated in every variable that uses or will use access_ip