Automatically derive defaults versions from checksums #11906
+264
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
kind/feature
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/M
|
(I've put this as draft because I don't think it can pass tests without #11890 merged) |
VannTen
force-pushed
the
feat/automatic_default_version_upgrade
branch
from
7ae4dde to
ced302a
Compare
k8s-ci-robot
added
the
needs-rebase
Currently, when updating checksums, we manually update the default versions. However, AFAICT, for all components where we have checksums, we're using the newest version out of those checksums. Codify this in the `_version` defaults variables definition to make the process automatic and reduce manual steps (as well as the diff size during reviews). We assume the versions are sorted, with newest first. This should be guaranteed by the pre-commit hooks.
The pre-commit hook introduced a142f40 (Update versions in README.md with pre-commit, 2025-01-21) allow to update our README with new versions. It turns out other "static" files (== which don't interpret Ansible variables) also use the default version (in that case, our Dockefiles, but there might be others) The Dockerfile breaks if the variable they use (`kube_version`) is a Jinja template. For helping with automatic version upgrade, generalize the hook to deal with other static files, and make a template out of the Dockerfile.
All the ansible/python tooling for version is for version strings. YAML unhelpfully consider some stuff as number, so enforce this.
VannTen
force-pushed
the
feat/automatic_default_version_upgrade
branch
from
ced302a to
191ec7b
Compare
k8s-ci-robot
added
size/L
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
I expect a conflict with #11890 (since I stringified the versions here) but I'll fix it in whatever PR does not merge first. |
|
/retest-failed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Currently, when updating checksums, we manually update the default versions.
However, AFAICT, for all components where we have checksums, we're using the newest version out of those checksums.
Codify this in the
_versiondefaults variables definition to make the process automatic and reduce manual steps (as well as the diff size during reviews).With this and:
we should have a pretty good story for automatic versions upgrades, hands-off. Just need to find how to run the updater + pre-commit and make a PR out of that.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/label ci-extended
(as we're touching versions of several stuff)
Does this PR introduce a user-facing change?: