Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OWNERS file for recover_control_plane #5505

Merged
merged 1 commit into from
Mar 16, 2020

Conversation

yujunz
Copy link
Member

@yujunz yujunz commented Jan 2, 2020

Related to #5432

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Offering helps on #5432

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Volunteer to help maintaining the role recover_control_plane

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 2, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jan 2, 2020
@yujunz
Copy link
Member Author

yujunz commented Jan 2, 2020

Added also the original author. Let me know if it is OK for you, @qvicksilver

@qvicksilver
Copy link
Contributor

Added also the original author. Let me know if it is OK for you, @qvicksilver

No problem!

@Miouge1
Copy link
Contributor

Miouge1 commented Jan 6, 2020

@k8s-ci-robot is not happy because you are not yet member of the kubernetes-sigs GitHub org. Check https://github.com/kubernetes/community/blob/master/community-membership.md to see how to join to Kubernetes-sigs GitHub org.

@Miouge1 Miouge1 self-assigned this Jan 6, 2020
@yujunz
Copy link
Member Author

yujunz commented Jan 6, 2020

Yeah, I saw that. May I add you as one of the sponsors? @Miouge1

@Miouge1
Copy link
Contributor

Miouge1 commented Jan 9, 2020

@yujunz sure!

@yujunz
Copy link
Member Author

yujunz commented Jan 14, 2020

Please find my application for community membership in kubernetes/org#1560 @Miouge1

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jan 17, 2020
@yujunz
Copy link
Member Author

yujunz commented Jan 17, 2020

@k8s-ci-robot is happy now. cc @Miouge1

@Miouge1
Copy link
Contributor

Miouge1 commented Mar 14, 2020

@yujunz now @qvicksilver is part of the GitHub org, can we have of you in the OWNERS file?

@yujunz
Copy link
Member Author

yujunz commented Mar 15, 2020

@yujunz now @qvicksilver is part of the GitHub org, can we have of you in the OWNERS file?

Amended. I think @qvicksilver had agreed before. Let me know if it is still good for you.

@qvicksilver
Copy link
Contributor

Still fine by me!

@Miouge1
Copy link
Contributor

Miouge1 commented Mar 16, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miouge1, yujunz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit ceab27c into kubernetes-sigs:master Mar 16, 2020
@yujunz yujunz deleted the owners branch March 16, 2020 10:47
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants