-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ppc64le architecture to kubetest2 available archs #289
Add ppc64le architecture to kubetest2 available archs #289
Conversation
/sig k8s-infra |
@Rajalakshmi-Girish can you link to the discussion and the kubekins issue you have created? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test pull-kubetest2-gce-legacy-up-down |
/assign @aojea @michelle192837 @upodroid /lgtm |
not much involved on the discussions but following the threads it seems there is a positive feedback on this so I'm going to approve to unblock the work /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, mkumatag, Prajyot-Parab, Rajalakshmi-Girish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Addition of
ppc64le
arch worked fine when I ranmake ci-binaries
. The resulted file had below details when built on x86 machine:This change is needed for
kubekins-e2e-v2
support on ppc64le. As at https://github.com/kubernetes/test-infra/blob/master/images/kubekins-e2e-v2/Dockerfile#L168 kubetest2 is referred.kubekins
issue :kubernetes/test-infra#34345
Slack discussion: https://kubernetes.slack.com/archives/CCK68P2Q2/p1739538851706299?thread_ts=1739359083.466129&cid=CCK68P2Q2