Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ppc64le architecture to kubetest2 available archs #289

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

Rajalakshmi-Girish
Copy link
Contributor

@Rajalakshmi-Girish Rajalakshmi-Girish commented Feb 18, 2025

Addition of ppc64le arch worked fine when I ran make ci-binaries. The resulted file had below details when built on x86 machine:

[root@raji-x86-workspace1 ppc64le]# file kubetest2
kubetest2: ELF 64-bit LSB executable, 64-bit PowerPC or cisco 7500, version 1 (SYSV), statically linked, with debug_info, not stripped
[root@raji-x86-workspace1 ppc64le]#

This change is needed for kubekins-e2e-v2 support on ppc64le. As at https://github.com/kubernetes/test-infra/blob/master/images/kubekins-e2e-v2/Dockerfile#L168 kubetest2 is referred.

kubekins issue :
kubernetes/test-infra#34345
Slack discussion: https://kubernetes.slack.com/archives/CCK68P2Q2/p1739538851706299?thread_ts=1739359083.466129&cid=CCK68P2Q2

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 18, 2025
@Rajalakshmi-Girish
Copy link
Contributor Author

/sig k8s-infra

@k8s-ci-robot k8s-ci-robot added the sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. label Feb 18, 2025
@mkumatag
Copy link
Member

@Rajalakshmi-Girish can you link to the discussion and the kubekins issue you have created?

Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2025
Copy link

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Rajalakshmi-Girish
Copy link
Contributor Author

/test pull-kubetest2-gce-legacy-up-down

@dims
Copy link
Member

dims commented Feb 19, 2025

/assign @aojea @michelle192837 @upodroid

/lgtm

@aojea
Copy link
Contributor

aojea commented Feb 19, 2025

not much involved on the discussions but following the threads it seems there is a positive feedback on this so I'm going to approve to unblock the work

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, mkumatag, Prajyot-Parab, Rajalakshmi-Girish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1cc02ed into kubernetes-sigs:master Feb 19, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants