Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kjobctl] Skip kueue labels on child objects. #3455

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[kjobctl] Skip kueue labels on child objects. #3455

wants to merge 1 commit into from
+48 −14

Conversation

mbobrovskyi
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

We don't need to add kueue labels to child objects like ConfigMap or Service.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Nov 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mbobrovskyi
Once this PR has been reviewed and has the lgtm label, please assign trasc for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 5, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 5, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit e15bc18
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/672a0a2f6a74fd0008ff0557
😎 Deploy Preview https://deploy-preview-3455--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mimowo
Copy link
Contributor

mimowo commented Nov 5, 2024

cc @mwysokin

trasc
trasc reviewed Nov 5, 2024
View reviewed changes
cmd/experimental/kjobctl/pkg/builder/slurm_builder.go
@@ -190,6 +190,26 @@ func (b *slurmBuilder) validateMutuallyExclusiveFlags() error {
return nil
}

func (b *slurmBuilder) buildObjectMeta(templateObjectMeta metav1.ObjectMeta) metav1.ObjectMeta {
objectMeta := b.Builder.buildObjectMeta(templateObjectMeta)
objectMeta.GenerateName = ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks strange, maybe b.Builder.buildObjectMeta(templateObjectMeta) should not set GeneratName if it's not generally useful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s used in other modes. Only Slurm no need it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trasc trasc trasc left review comments

@mimowo mimowo Awaiting requested review from mimowo

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mbobrovskyi @k8s-ci-robot @mimowo @trasc