[Cleanup] Use PROJECT_DIR for crd path instead of indirect path #4054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
|
/assign @mbobrovskyi |
mszadkow
force-pushed
the
feature/improve-int-test-crds-path
branch
from
4bba3b5 to
070e17b
Compare
mbobrovskyi
reviewed
Jan 24, 2025
mszadkow
force-pushed
the
feature/improve-int-test-crds-path
branch
from
070e17b to
a0761f0
Compare
mbobrovskyi
reviewed
Jan 24, 2025
test/integration/controller/admissionchecks/provisioning/suite_test.go
Outdated
Show resolved
Hide resolved
mszadkow
force-pushed
the
feature/improve-int-test-crds-path
branch
from
dae4023 to
dbcec7d
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: ca709ff1e92400b34b49e1abbcda5cc3c8e436c1
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mimowo, mszadkow The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Indirect path to CRDs are confusing and varies depending on the folder structure.
Make them follow one direct path based on the PROJECT_DIR.
Which issue(s) this PR fixes:
Relates #4040
Special notes for your reviewer:
Does this PR introduce a user-facing change?