New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test "Can perform a rolling update with subgroupsize and MaxSurge set" #222

Open

ahg-g opened this issue Sep 14, 2024 · 1 comment

Assignees

Labels

kind/bug

Contributor

ahg-g commented Sep 14, 2024

Log: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_lws/217/pull-lws-test-e2e-main-1-31/1834756867335655424

/assign @Edwinhr716

ahg-g added the kind/bug label

k8s-ci-robot assigned Edwinhr716

ahg-g mentioned this issue

Update installation guide #217

Merged

Contributor

Edwinhr716 commented Oct 3, 2024

Test follows the same checks and format as the other rollingUpdate + MaxSurge tests. The same line that fails https://github.com/kubernetes-sigs/lws/blob/main/test/e2e/e2e_test.go#L184, works on other MaxSurge tests https://github.com/kubernetes-sigs/lws/blob/main/test/e2e/e2e_test.go#L138. The test itself checks if MaxSurge still works if subgroupsize is set. The only thing that subGroupSize sets is labels, so there's no reason for it to fail in this case but succeed in others, which means it is a race condition.

Not sure what the solution would be here which would not make it different from other maxSurge tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment