Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation guide #217

Merged
merged 1 commit into from
Sep 14, 2024
Merged

Conversation

liurupeng
Copy link
Collaborator

@liurupeng liurupeng commented Sep 14, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #

Special notes for your reviewer

Does this PR introduce a user-facing change?


@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liurupeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 14, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 14, 2024
@ahg-g
Copy link
Contributor

ahg-g commented Sep 14, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2024
@liurupeng
Copy link
Collaborator Author

/retest

@ahg-g
Copy link
Contributor

ahg-g commented Sep 14, 2024

@liurupeng: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-lws-test-e2e-main-1-31 61ca489 link true /test pull-lws-test-e2e-main-1-31
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

We should investigate this, it could be a bug.

@k8s-ci-robot k8s-ci-robot merged commit 6d42914 into kubernetes-sigs:main Sep 14, 2024
8 checks passed
@ahg-g
Copy link
Contributor

ahg-g commented Sep 14, 2024

@liurupeng: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
pull-lws-test-e2e-main-1-31 61ca489 link true /test pull-lws-test-e2e-main-1-31
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

We should investigate this, it could be a bug.

@Edwinhr716 the failed test is related to the subgroup feature, please open an issue to track this and investigate it.

@ahg-g
Copy link
Contributor

ahg-g commented Sep 14, 2024

Opened #222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants