-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add updatedReplicas to Status #83
Add updatedReplicas to Status #83
Conversation
Signed-off-by: kerthcet <[email protected]>
Signed-off-by: kerthcet <[email protected]>
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kerthcet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -40,7 +40,7 @@ import ( | |||
) | |||
|
|||
const ( | |||
timeout = 1 * time.Minute | |||
timeout = 30 * time.Second |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why? are we not concerned this will make it flaky?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Timeout is shared by integration-test and e2e-test, 1 minute is too long for waiting integration test to fail if we have. We can fasten this if necessary, but right now, 30s is enough for what I'm testing. (I added some optimizations like update the name rather than the image which will slow down the rolling update process)
Signed-off-by: kerthcet <[email protected]>
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it
Which issue(s) this PR fixes
part of #3
Special notes for your reviewer
Does this PR introduce a user-facing change?