-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Tiny button next to each feature for Documentation link #88
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zitudu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @zitudu! |
ping @medyagh @spowelljr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @zitudu thank you for this contribution can we make the icon smaller and tiny and also change the grapgic to look like documentaion?
Thx for your reviewing. The link button is now smaller and align bottom. The external link symbol is widely used to open resource links, such as the minikube-gui documentation page also uses this symbol. Any suggestions, please? |
ping @medyagh @spowelljr |
Hi @medyagh I'm still waiting for your reply. Could you please tell me more information about this issue? |
sorry @zitudu for the long wait, can we change the icon to something else? maybe "i" information icon ? and maybe it should be gray and only be Darker if you Hover over it it. and then it should tooltip "documentation" |
@zitudu thanks for the new update, looks better but the build failed, plz take a look |
|
@medyagh This is due to the different signatures of this method in qt5 and qt6. I added support for qt5 and built it successfully locally. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Implemented issue #25. Will open URL like https://minikube.sigs.k8s.io/docs/commands/XXX using the default browser.