Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update implementations status #257

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Update implementations status #257

merged 1 commit into from
Oct 29, 2024

Conversation

tssurya
Copy link
Contributor

@tssurya tssurya commented Oct 22, 2024

The status of implementations was outdated, let's clean that up

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 22, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 22, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-network-policy-api ready!

Name Link
🔨 Latest commit ddb8cfa
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-network-policy-api/deploys/6720951f5bd2c5000863a9bd
😎 Deploy Preview https://deploy-preview-257--kubernetes-sigs-network-policy-api.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aojea
Copy link
Contributor

aojea commented Oct 22, 2024

/lgtm
/cc @bowei

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2024
@tssurya
Copy link
Contributor Author

tssurya commented Oct 22, 2024 •
edited
Loading

Kube-OVN has also finished implementing this kubeovn/kube-ovn#3247... let me update the list to show that
I can open up a follow up once I hear back from them: kubeovn/kube-ovn#3247 (comment)

@tssurya tssurya mentioned this pull request Oct 22, 2024
Closed
@danwinship
Copy link
Contributor

/approve
/hold
for reply from kube-ovn (but feel free to unhold if we don't hear back right away)

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 22, 2024
astoycos
astoycos reviewed Oct 29, 2024
View reviewed changes
Copy link
Member

@astoycos astoycos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks for updating!

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astoycos, danwinship, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [astoycos,danwinship]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tssurya
Copy link
Contributor Author

tssurya commented Oct 29, 2024

/hold cancel
I have updated the list and added KubeOVN as well to the mix

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2024
@tssurya
Update implementations status
ddb8cfa 
Signed-off-by: Surya Seetharaman <[email protected]>
@danwinship
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit eeda623 into kubernetes-sigs:main Oct 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astoycos astoycos astoycos left review comments

@danwinship danwinship Awaiting requested review from danwinship

@Dyanngg Dyanngg Awaiting requested review from Dyanngg

@bowei bowei Awaiting requested review from bowei

Assignees

@danwinship danwinship

@aojea aojea

@astoycos astoycos

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tssurya @aojea @danwinship @k8s-ci-robot @astoycos