-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for blunderbuss to wait for tide status #349
base: main
Are you sure you want to change the base?
Conversation
Hi @dobesv. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for k8s-prow ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/ok-to-test |
/retest |
I probably would need some guidance how to resolve that failure in |
Currently, the command-help page renders multiline command examples (the only example I've seen is for /release-note-edit) on one line, which is confusing for users. Change the style to respect newline in the source. Link: https://developer.mozilla.org/en-US/docs/Web/CSS/white-space
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dobesv The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Seems this is a bit inconsistent with tide.
As a code reviewer, I don't want to review code which has not passed the test suites yet.
If I am asked to review something and then the tests fail after my review, it feels like I wasted my time as the person submitting it has to address the feedback from the tools anyway. However, if I do not review it immediately then I have to manually check back later to see whether the tests have passed - there is no way currently to set up a notification for tests passing under the current system.
This change allows configuring blunderbuss to request reviews when a matching commit status is reported instead of immediately when the pull request is opened or marked as ready for review. By setting the condition to one which matches the status that
tide
posts when all tests have passed but it is waiting for a label or for GitHub reviews to be posted, I can defer the automated review requests until the tests have passed.This way someone can open a pull request, and when they eventually get all the tests passing, I can be prompted to review the pull request. I won't waste time reviewing a pull request that has failing tests or lint errors, and I also will not have to manually "check back" on all the pull requests to see which ones have the tests passing.
For example in this project, you could in theory set up blunderbuss to wait with requesting reviews until tide shows this status: