fix: update the hash generation logic #1676
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anish Ramasekar <[email protected]>
Signed-off-by: Anish Ramasekar <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aramase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1676 +/- ##
==========================================
+ Coverage 35.83% 36.61% +0.78%
==========================================
Files 63 63
Lines 3759 4536 +777
==========================================
+ Hits 1347 1661 +314
- Misses 2268 2731 +463
Partials 144 144 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind bug
Fix the hash generation logic to prevent hash collision with different maps as input. This can be caused because of the concatenation logic.
The test added in b94492d shows the bug in the current logic.
=== RUN TestGenerateSHAFromSecret/different_keys_with_the_same_concatenated_result_but_should_not_match secret_test.go:434: Error Trace: /Users/anishramasekar/go/src/sigs.k8s.io/secrets-store-csi-driver/pkg/util/secretutil/secret_test.go:434 Error: Not equal: expected: false actual : true Test: TestGenerateSHAFromSecret/different_keys_with_the_same_concatenated_result_but_should_not_match --- FAIL: TestGenerateSHAFromSecret/different_keys_with_the_same_concatenated_result_but_should_not_match (0.00s)/assign enj