-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update the hash generation logic #1676
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Anish Ramasekar <[email protected]>
Signed-off-by: Anish Ramasekar <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aramase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1676 +/- ##
==========================================
+ Coverage 35.83% 36.61% +0.78%
==========================================
Files 63 63
Lines 3759 4536 +777
==========================================
+ Hits 1347 1661 +314
- Misses 2268 2731 +463
Partials 144 144 ☔ View full report in Codecov by Sentry. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/kind bug
Fix the hash generation logic to prevent hash collision with different maps as input. This can be caused because of the concatenation logic.
The test added in b94492d shows the bug in the current logic.
/assign enj