Skip to content

Commit

Permalink
Fix nodeselector to nodeSelector in Helm chart
Browse files Browse the repository at this point in the history
Currently, the default `nodeselector` in the `values.yaml` of the Helm chart is incorrect since it doesn't actually do anything.

```bash
$ helm template --set="nodeselector.hi=bye" gmsa charts/gmsa | yq e 'select(.kind == "Deployment") | .spec.template.spec.nodeSelector'
kubernetes.io/os: linux

$ helm template --set="nodeSelector.hi=bye" gmsa charts/gmsa | yq e 'select(.kind == "Deployment") | .spec.template.spec.nodeSelector'
kubernetes.io/os: linux
hi: bye
```

To fix this, I'm simply modifying `nodeselector` to `nodeSelector` in the default `values.yaml`.
  • Loading branch information
Arvind Iyengar committed Sep 29, 2023
1 parent 7f48de9 commit a3020b7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion charts/gmsa/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ global:
systemDefaultRegistry: ""

affinity: {}
nodeselector: {}
nodeSelector: {}
podDisruptionBudget:
enabled: false
# minAvailable: 1
Expand Down

0 comments on commit a3020b7

Please sign in to comment.