-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-3243: Update the design to mutate the label selector based on matchLabelKeys at api-server instead of the scheduler handling it #5033
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mochizuki875 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @sanposhiho |
/cc @alculquicondor @wojtek-t (or @alculquicondor) do we need PRR review in this case? (I suppose Yes?) |
/retitle KEP-3243: Update the design to mutate the label selector based on matchLabelKeys at api-server instead of the scheduler handling it |
cc @dom4ha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the content based on the conclusion kubernetes/kubernetes#129480 (comment)
existing pods over which spreading will be calculated. | ||
|
||
A new field named `MatchLabelKeys` will be introduced to`TopologySpreadConstraint`: | ||
A new optional field named `MatchLabelKeys` will be introduced to`TopologySpreadConstraint`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep this part.
A new optional field named `MatchLabelKeys` will be introduced to`TopologySpreadConstraint`. | |
A new optional field named `MatchLabelKeys` will be introduced to`TopologySpreadConstraint`. | |
Currently, when scheduling a pod, the `LabelSelector` defined in the pod is used | |
to identify the group of pods over which spreading will be calculated. | |
`MatchLabelKeys` adds another constraint to how this group of pods is identified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to update other sections such as Test Plan
and other PRR questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please add the current implementation for Alternative
section and describe why we decided to move to a new approach.
labelSelector.