Skip to content

Commit

Permalink
test justin's patch in #16125
Browse files Browse the repository at this point in the history
  • Loading branch information
upodroid committed Nov 23, 2023
1 parent 8f749a5 commit 8511727
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions cmd/kops/create_cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -408,9 +408,9 @@ func NewCmdCreateCluster(f *util.Factory, out io.Writer) *cobra.Command {
return []string{"json", "yaml"}, cobra.ShellCompDirectiveNoFileComp
})

cmd.Flags().StringSliceVar(&options.Sets, "override", options.Sets, "Directly set values in the spec")
cmd.Flags().StringArrayVar(&options.Sets, "override", options.Sets, "Directly set values in the spec")
cmd.Flags().MarkDeprecated("override", "use --set instead")
cmd.Flags().StringSliceVar(&options.Sets, "set", options.Sets, "Directly set values in the spec")
cmd.Flags().StringArrayVar(&options.Sets, "set", options.Sets, "Directly set values in the spec")
cmd.RegisterFlagCompletionFunc("set", func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
return nil, cobra.ShellCompDirectiveNoFileComp
})
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/kubetest2-kops/deployer/up.go
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ func (d *deployer) createCluster(zones []string, adminAccess string, yes bool) e
"--kubernetes-version", d.KubernetesVersion,
"--ssh-public-key", d.SSHPublicKeyPath,
"--set", "cluster.spec.nodePortAccess=0.0.0.0/0",
"--set", `spec.containerd.configAdditions="plugins.""io.containerd.grpc.v1.cri"".containerd.runtimes.test-handler.runtime_type=""io.containerd.runc.v2"""`,
"--set", `spec.containerd.configAdditions=plugins."io.containerd.grpc.v1.cri".containerd.runtimes.test-handler.runtime_type="io.containerd.runc.v2"`,
}
if yes {
args = append(args, "--yes")
Expand Down

0 comments on commit 8511727

Please sign in to comment.