-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update haproxy and keepalived config #3060
Conversation
Welcome @nijave! |
Hi @nijave. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
/approve
/kind documentation
/cc @mbert
@neolit123: GitHub didn't allow me to request PR reviews from the following users: mbert. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. As the timeout values are concerned, the reason for increasing them was given in the original ticket, however I'd still be interested to understand why they need to be that high.
I'm not sure they necessarily need to be that high--I'm not sure if Kubernetes does any sort of keepalives but they would ideally be set around what k8s has Edit looks like 1800s is what kube-apiserver is using for watches
https://kubernetes.io/docs/reference/command-line-tools-reference/kube-apiserver/ There's also
Edit 2: |
I found kubernetes/kubernetes#95981 which would explain the 30s interval I'm seeing. I also asked in Kubernetes Slack https://kubernetes.slack.com/archives/C09NXKJKA/p1714925405232349 With that info, maybe 35s is more reasonable? |
Additional context kubernetes#3060 (comment)
Yes, definitely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please squash the commits to one, then this can merge.
Shrink timeouts Additional context kubernetes#3060 (comment)
efddb0b
to
073082b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
thanks for the changes!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123, nijave The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Closes #3052