Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aggregated v2beta1 client-side usage #129867

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jefftree
Copy link
Member

@Jefftree Jefftree commented Jan 28, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Remove client-go usage of aggregated discovery v2beta1 type. Server side change will be done in a separate PR since emulation version may be involved.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

pull-kubernetes-apidiff-client-go failure is expected as the beta type is dropped.

Does this PR introduce a user-facing change?

client-go will only query aggregated discovery using `apidiscovery.k8s.io/v2` and drop support for `apidiscovery.k8s.io/v2beta1`

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


/triage accepted

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. triage/accepted Indicates an issue or PR is ready to be actively worked on. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 28, 2025
@k8s-ci-robot k8s-ci-robot added area/apiserver area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 28, 2025
@Jefftree Jefftree force-pushed the remove-client-agg-discovery-v2beta1 branch from b459832 to 131b03b Compare January 28, 2025 19:50
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jefftree
Once this PR has been reviewed and has the lgtm label, please assign aojea for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jefftree
Copy link
Member Author

/assign @jpbetz @seans3

@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@k8s-ci-robot
Copy link
Contributor

@Jefftree: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-apidiff-client-go 131b03b link false /test pull-kubernetes-apidiff-client-go
pull-kubernetes-typecheck 131b03b link true /test pull-kubernetes-typecheck
pull-kubernetes-conformance-kind-ga-only-parallel 131b03b link true /test pull-kubernetes-conformance-kind-ga-only-parallel
pull-kubernetes-e2e-kind-ipv6 131b03b link true /test pull-kubernetes-e2e-kind-ipv6
pull-kubernetes-integration 131b03b link true /test pull-kubernetes-integration
pull-kubernetes-e2e-kind 131b03b link true /test pull-kubernetes-e2e-kind
pull-kubernetes-e2e-gce 131b03b link true /test pull-kubernetes-e2e-gce
pull-kubernetes-node-e2e-containerd 131b03b link true /test pull-kubernetes-node-e2e-containerd
pull-kubernetes-unit 131b03b link true /test pull-kubernetes-unit
pull-kubernetes-verify 131b03b link true /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apiserver area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants