Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the scheduler framework pending state. #130228

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed the scheduler framework pending state. #130228

wants to merge 1 commit into from
+4 −1

Conversation

thisisharrsh
Copy link

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #129405

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 18, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Feb 18, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: thisisharrsh
Once this PR has been reviewed and has the lgtm label, please assign alculquicondor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 18, 2025
@thisisharrsh thisisharrsh mentioned this pull request Feb 18, 2025
Closed
googs1025
googs1025 reviewed Feb 18, 2025
View reviewed changes
pkg/scheduler/framework/runtime/framework.go
@@ -746,6 +746,9 @@ func (f *frameworkImpl) RunPreFilterPlugins(ctx context.Context, state *framewor
returnStatus = s
continue
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add comments to the pending field to prevent users from ignoring this rule when calling, rather than adding comments when the code returns.

googs1025
googs1025 reviewed Feb 18, 2025
View reviewed changes
pkg/scheduler/framework/runtime/framework.go
@@ -736,7 +736,7 @@ func (f *frameworkImpl) RunPreFilterPlugins(ctx context.Context, state *framewor
s.SetPlugin(pl.Name())
if s.Code() == framework.UnschedulableAndUnresolvable {
// In this case, the preemption shouldn't happen in this scheduling cycle.
// So, no need to execute all PreFilter.
// So, no need to execute all PreFilter.k
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: is this forget to remove?

sanposhiho
sanposhiho reviewed Feb 18, 2025
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant, can you enhance the comment here:
https://github.com/kubernetes/kubernetes/blob/master/pkg/scheduler/framework/interface.go#L243

@thisisharrsh
Copy link
Author

I meant, can you enhance the comment here:

Oh, my bad. I'll close this PR too and make the changes in the file soon.

@googs1025
Copy link
Member

you can just do in this pr

I meant, can you enhance the comment here:

Oh, my bad. I'll close this PR too and make the changes in the file soon.

@sanposhiho
Copy link
Member

Yeah, you can just update this PR. The reason last time I suggested recreating the PR is because that was a huge direction change

@googs1025
Copy link
Member

and also renew pr title and commit info :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanposhiho sanposhiho sanposhiho left review comments

@googs1025 googs1025 googs1025 left review comments

@AxeZhan AxeZhan Awaiting requested review from AxeZhan

@damemi damemi Awaiting requested review from damemi

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pending should not be handled as Error in PreFilter
4 participants
@thisisharrsh @k8s-ci-robot @googs1025 @sanposhiho