Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jongwooo to sig-docs-ko-owners #5338

Merged
merged 1 commit into from
Mar 9, 2025
Merged

Add jongwooo to sig-docs-ko-owners #5338

merged 1 commit into from
Mar 9, 2025

Conversation

jongwooo
Copy link
Member

Add @jongwooo to sig-docs-ko-owners
ref: kubernetes/website#49425

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/github-management Issues or PRs related to GitHub Management subproject labels Jan 14, 2025
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 14, 2025
sftim
sftim reviewed Jan 14, 2025
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jihoon-seo
Copy link
Member

@jongwooo has been so actively contributing to k/w repo regarding Korean l10n. LGTM too!

@divya-mohan0209
Copy link
Contributor

LGTM from me!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2025
@sftim
Copy link
Contributor

sftim commented Mar 9, 2025 •
edited
Loading

/lgtm

@divya-mohan0209 suggest you approve this change (it's not a change to the live docs so there's no process barrier to you approving it)

@sftim
Copy link
Contributor

sftim commented Mar 9, 2025

/approve

I don't think I can approve this formally, but given kubernetes/website#49425 I do agree with making this change.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jongwooo, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2025
@k8s-ci-robot k8s-ci-robot merged commit b6ad60e into kubernetes:main Mar 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@katcosgrove katcosgrove Awaiting requested review from katcosgrove

@onlydole onlydole Awaiting requested review from onlydole

Assignees

@divya-mohan0209 divya-mohan0209

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jongwooo @jihoon-seo @divya-mohan0209 @sftim @k8s-ci-robot