Skip to content

Commit

Permalink
Merge pull request #2373 from sreeram-venkitesh/adding-sync-job-instr…
Browse files Browse the repository at this point in the history
…uctions-to-enhancements-handbook

Added instructions for enabling/disabling enhancement sync job to enhancements handbook
  • Loading branch information
k8s-ci-robot authored Apr 24, 2024
2 parents 9a80039 + bf6dedb commit d32a5d4
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions release-team/role-handbooks/enhancements/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,8 @@ It is important that this process be followed and documentation remain up-to-dat
- @release-team-comms
- @release-team-docs
- @release-team-enhancements
- @prod-readiness-reviewers
- Add the @k8s-infra-ci-robot account to the board with **Write** access.
- Create all the Fields (columns) for the board
> Note: This is currently a manual process and <https://github.com/orgs/community/discussions/41133> filed to help automate the process.
- Until this can be automated; manually create fields with the same `Field Name`, `Field type`, and `Option` values from the previous release's project board.
Expand All @@ -135,8 +137,9 @@ It is important that this process be followed and documentation remain up-to-dat
- Disable all Workflows for the project
- Click `...` -> `Workflows`
- For each workflow that enabled (has a green circle next to it), click the workflow and slide the toggle to 'Off'
- Update automation to add issues to the correct Enhancement Tracking Board
- Open a PR into kubernetes/test-infra which to update the [`GITHUB_PROJECT_BETA_NUMBER`](https://github.com/kubernetes/test-infra/blob/3de59f96b327c87c6d23a7308abc785268931707/config/jobs/kubernetes/sig-k8s-infra/trusted/sig-release-release-team-jobs/release-team-periodics.yaml#L20-L21) variable used by automation to identity the enhancements tracking board for the current release.
- Update automation to add issues to the correct Enhancement Tracking Board. Open a PR into [kubernetes/test-infra](https://github.com/kubernetes/test-infra) with the following changes:
- Update the [`GITHUB_PROJECT_BETA_NUMBER`](https://github.com/kubernetes/test-infra/blob/3de59f96b327c87c6d23a7308abc785268931707/config/jobs/kubernetes/sig-k8s-infra/trusted/sig-release-release-team-jobs/release-team-periodics.yaml#L20-L21) variable used by automation to identity the enhancements tracking board for the current release.
- Enable the test-infra job that syncs enhancements to the GitHub project board based on the `lead-opt-in` label. Update the name of the [periodic-sync-enhancements-github-project](https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-k8s-infra/trusted/sig-release-release-team-jobs/release-team-periodics.yaml#L2) cronjob with the version number of the release and enable the cronjob by commenting the impossible cron and uncommenting the `interval`. You can see how this was done for the v1.29 release cycle in [this commit](https://github.com/kubernetes/test-infra/pull/30528/files#diff-9d86ca0a46a2f74a2cf59fff3d18cbba57b5b3489ecc00c36b03f6b6a0c2ac3a).
- Create a shortlink for the Tracking Board
- Create a free account on [bitly](https://bitly.com/) to create a shortlink for the new Enhancement Tracking Board following the pattern `k8sxyy-enhancements`, e.g. <https://bit.ly/k8s127-enhancements>.
- Make a [pull request](https://github.com/kubernetes/sig-release/pull/1411) to add the shortlinked Enhancement Tracking Board to the current release page in [sig-release][sig-release].
Expand Down Expand Up @@ -245,6 +248,8 @@ See the sig-architecture Enhancements [KEP Template](https://github.com/kubernet
- Make sure that number of in-tree open issues with current milestone matches number of opted-in enhancements by checking the Enhancements Tracking Board and GitHub issues with the current milestone. **Note**: in-tree refers to KEPs with PRs inside the [kubernetes/kubernetes](https://github.com/kubernetes/kubernetes) repository.
- If a previously removed Enhancement has had their exception Approved, set their **Enhancement Status** to `tracked for enhancement freeze` in the Enhancement Tracking Board.
- On Freeze day, email [Kubernetes-Dev](https://groups.google.com/a/kubernetes.io/g/dev) that freeze has happened and upcoming key dates. Examples [1](https://groups.google.com/g/kubernetes-dev/c/JDM7bNKvhqQ/m/8S7BXtXPBQAJ).
- Disable the [periodic-sync-enhancements-github-project](https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-k8s-infra/trusted/sig-release-release-team-jobs/release-team-periodics.yaml#L2) cronjob which syncs enhancements where the `lead-opt-in` label has been added to the GitHub project board.
- Disable the job by commenting the `interval` and uncommenting the impossible cron date. You can see how this was done in the v1.29 release in [this commit](https://github.com/kubernetes/test-infra/commit/064dd07f0164c2aadc12d611f5a851d6cc40afdd).
- Remove any Enhancements that failed to meet the criteria by the Enhancement freeze deadline.
- Set their **Enhancement Status** in the board to `Removed from Milestone`.
- Remove the milestone.
Expand Down

0 comments on commit d32a5d4

Please sign in to comment.