Add release team lead shadows as approvers #2628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/documentation
k8s-ci-robot
added
the
area/release-team
k8s-ci-robot
added
sig/release
saschagrunert
approved these changes
Sep 18, 2024
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: npolshakova, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@npolshakova my only comment is that they are not sorted, not sure if this is mandatory everywhere since I do not see an error in the tests... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind documentation
What this PR does / why we need it:
Part of the 1.32 release team checklist has a task to
Add an approvers entry in releases/release-1.XX/OWNERS,For the 1.32 OWNERS file, the last release we had only the release lead and Emeritus advisor as approvers, but in previous releases all the lead shadows also had approval permissions. This allows release team lead shadows to also approve release-notes PRs going into 1.32.
Which issue(s) this PR fixes:
None