Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KEP-3041] - remove node special feature and node alpha feature from test-infra for non release branch #33828

Merged
merged 1 commit into from
Dec 17, 2024
Merged

[KEP-3041] - remove node special feature and node alpha feature from test-infra for non release branch #33828

merged 1 commit into from
Dec 17, 2024
+48 −84

Conversation

kannon92
Copy link
Contributor

Address the test-infra part of #33823.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 21, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 21, 2024
@kannon92
Copy link
Contributor Author

/hold

We should merge this once 1.33 opens up for development.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2024
@kannon92 kannon92 mentioned this pull request Nov 21, 2024
Open
@kannon92 kannon92 force-pushed the remove-node-special-feature branch from b05916b to 0e45a9a Compare November 21, 2024 21:25
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 21, 2024
@kannon92 kannon92 changed the title remove node special feature from test-infra for non release branch remove node special feature and node alpha feature from test-infra for non release branch Nov 21, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 22, 2024
@kannon92 kannon92 force-pushed the remove-node-special-feature branch from 0e45a9a to 754f624 Compare November 22, 2024 19:24
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 22, 2024
@kannon92 kannon92 force-pushed the remove-node-special-feature branch from 754f624 to fa5761f Compare December 2, 2024 14:23
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2024
AnishShah
AnishShah reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@AnishShah AnishShah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this as it is confusing me to me too.

AnishShah
AnishShah reviewed Dec 11, 2024
View reviewed changes
config/jobs/kubernetes/sig-node/containerd.yaml
@@ -227,7 +227,7 @@ periodics:
- '--node-test-args=--container-runtime-endpoint=unix:///run/containerd/containerd.sock --container-runtime-process-name=containerd --container-runtime-pid-file= --kubelet-flags="--cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/containerd.service" --extra-log="{\"name\": \"containerd.log\", \"journalctl\": [\"-u\", \"containerd*\"]}"'
- --node-tests=true
- --provider=gce
- --test_args=--nodes=1 --timeout=4h --focus="\[Serial\]" --skip="\[Flaky\]|\[Benchmark\]|\[NodeSpecialFeature:.+\]|\[NodeSpecialFeature\]|\[NodeAlphaFeature:.+\]|\[NodeAlphaFeature\]|\[NodeFeature:Eviction\]|\[NodeFeature:NodeSwap]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of removing, should we replace it with specific feature labels like Feature:PodLevelResource and Feature:InPlacePodVerticalScaling? This would allow us to exclude tests related to in-development features from certain jobs.

Copy link
Contributor

@AnishShah AnishShah Dec 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During the sig-node CI meeting, we discussed a strategy to submit your 2 changes. This approach would streamline the PR submission process. By replacing the generic labels NodeAlphaFeature and NodeSpecialFeature with specific feature labels, we can prioritize the submission of this PR, followed by the k/k PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was about a different item. In this case, We are skipping based on NodeSpecialFeature. I think we can drop this as is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case I think merging the k8s PR first and then this one is sufficient..

@kannon92 kannon92 changed the title remove node special feature and node alpha feature from test-infra for non release branch [KEP-3041] - remove node special feature and node alpha feature from test-infra for non release branch Dec 11, 2024
@kannon92
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2024
SergeyKanzhelev
SergeyKanzhelev approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kannon92, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f21d646 into kubernetes:master Dec 17, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@kannon92: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key containerd.yaml using file config/jobs/kubernetes/sig-node/containerd.yaml
  • key crio.yaml using file config/jobs/kubernetes/sig-node/crio.yaml
  • key ec2-containerd-presubmit.yaml using file config/jobs/kubernetes/sig-node/ec2-containerd-presubmit.yaml
  • key ec2-containerd.yaml using file config/jobs/kubernetes/sig-node/ec2-containerd.yaml
  • key node-kubelet.yaml using file config/jobs/kubernetes/sig-node/node-kubelet.yaml
  • key sig-node-presubmit.yaml using file config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

In response to this:

Address the test-infra part of #33823.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnishShah AnishShah AnishShah left review comments

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@endocrimes endocrimes Awaiting requested review from endocrimes

Assignees

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Node CI/Test Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kannon92 @k8s-ci-robot @AnishShah @SergeyKanzhelev