Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the outdated test_args of alpha-features testsuite of release branch jobs #34182

Conversation

Rajalakshmi-Girish
Copy link
Contributor

@Rajalakshmi-Girish Rajalakshmi-Girish commented Jan 20, 2025

Due to outdated Regex for test_args,
Master branch is running ~138 tests ci-kubernetes-e2e-gci-gce-alpha-features
whereas, the release branches are running ONLY 53 tests. ci-kubernetes-e2e-gce-cos-k8sbeta-alphafeatures

The gcp alpha-feature release branch jobs have been running outdated the test_args and were not changed with time.

The current regex in test_args of master branch job defined at https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml#L945 are applicable even for the release as old as1.29.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject labels Jan 20, 2025
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 20, 2025
@Rajalakshmi-Girish
Copy link
Contributor Author

The test_args for alpha features test suite was last updated 3 years ago and hence the regex in master branch job will applicable for oldest stable branch in release jobs 1.29.(stable-3)

image

@Rajalakshmi-Girish
Copy link
Contributor Author

@dims / @xmudrii Can you please review this?

@dims
Copy link
Member

dims commented Jan 28, 2025

verified that all the gates mentioned in focus do exist.. well except for PodPreset, we can remove that in a follow up PR from these jobs as well as the master job i think (we can decide later).

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, Rajalakshmi-Girish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit 2ad9ec9 into kubernetes:master Jan 28, 2025
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@Rajalakshmi-Girish: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key generated.yaml using file config/jobs/kubernetes/generated/generated.yaml

In response to this:

Due to outdated Regex for test_args,
Master branch is running ~138 tests ci-kubernetes-e2e-gci-gce-alpha-features
whereas, the release branches are running ONLY 53 tests. ci-kubernetes-e2e-gce-cos-k8sbeta-alphafeatures

The gcp alpha-feature release branch jobs have been running outdated the test_args and were not changed with time.

The current regex in test_args of master branch job defined at https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml#L945 are applicable even for the release as old as1.29.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants