Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove control 0086 #1562

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Remove control 0086 #1562

merged 2 commits into from
Dec 14, 2023

Conversation

yuleib
Copy link
Contributor

@yuleib yuleib commented Dec 13, 2023

Overview

@yuleib
removing control 0086
1dd8022 
Signed-off-by: Yuval Leibovich <[email protected]>
@yuleib
Update html-format.html
0d2a667 
Signed-off-by: Yuval Leibovich <[email protected]>
@yuleib
Copy link
Contributor Author

yuleib commented Dec 13, 2023 •
edited
Loading

related to PR: #1562
/
kubescape/regolibrary#555

@yuleib yuleib mentioned this pull request Dec 13, 2023
Merged
@yuleib
Copy link
Contributor Author

yuleib commented Dec 14, 2023

@dwertent - what is going on with the license issues ? why it is blocking the PR if it marked as passed ?

@matthyx
Copy link
Contributor

matthyx commented Dec 14, 2023

@dwertent - what is going on with the license issues ? why it is blocking the PR if it marked as passed ?

ignore pls

@yuleib
Copy link
Contributor Author

yuleib commented Dec 14, 2023

@matthyx - the builder tests are skipped because of it
00-pr_scanner / binary-build (pull_request) Skipped

@matthyx
Copy link
Contributor

matthyx commented Dec 14, 2023

@matthyx - the builder tests are skipped because of it 00-pr_scanner / binary-build (pull_request) Skipped

ok this CI is a mess, after my vacation I will really put some efforts in replacing that completely with kubescape/synchronizer#10

@yuleib
Copy link
Contributor Author

yuleib commented Dec 14, 2023

@matthyx so can i ignore and merge it ?

@matthyx
Copy link
Contributor

matthyx commented Dec 14, 2023

@matthyx so can i ignore and merge it ?

yes go

@yuleib yuleib merged commit 06d9c9d into master Dec 14, 2023
7 of 8 checks passed
@yuleib yuleib deleted the remove-control-0086 branch December 14, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwertent dwertent dwertent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuleib @matthyx @dwertent