Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multiple origins in authenticator #574

Open
f1ames opened this issue Nov 23, 2023 · 0 comments
Open

Handle multiple origins in authenticator #574

f1ames opened this issue Nov 23, 2023 · 0 comments
Labels

Comments

@f1ames
Copy link
Contributor

f1ames commented Nov 23, 2023

As described in https://github.com/kubeshop/monokle-saas/issues/2231:

Origin conflict between integration - when CLI logged in to enterprise, VSC ext will try to use those auth credentials (e.g. refresh token) for default origin (if not yet changed).

This is cumbersome in cases where I first login in with CLI and then start VSC (with Monokle ext) or when I will set origin in one workspace and then switch VSC to another project with different origin. Invalid token error occurs during extension initialization and it won't simply start which is quite an issue.

The idea is to store multiple origins in auth storage and make authenticator origin aware (so it knows which origin auth data to use). Also we will need to version auth data so authenticator know that it gets previous format and can either clean auth storage or migrate to new format without erroring.

Initial workaround was applied in #573.

@f1ames f1ames added enhancement New feature or request package/synchronizer labels Nov 23, 2023
@f1ames f1ames changed the title Handle multiple origins Handle multiple origins in authenticaotr Nov 23, 2023
@f1ames f1ames changed the title Handle multiple origins in authenticaotr Handle multiple origins in authenticator Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant