Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(synchronizer): allow to clear user data on origin conflict #573

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

f1ames
Copy link
Contributor

@f1ames f1ames commented Nov 23, 2023

This PR provides a workaround for origin conflicts.

As described in https://github.com/kubeshop/monokle-saas/issues/2231:

Origin conflict between integration - when CLI logged in to enterprise, VSC ext will try to use those auth credentials (e.g. refresh token) for default origin (if not yet changed).

This is cumbersome in cases where I first login in with CLI and then start VSC (with Monokle ext) or when I will set origin in one workspace and then switch VSC to another project with different origin. Invalid token error occurs during extension initialization and it won't simply start which is quite an issue.

Since refreshToken() method is used on initialization this is enough for now to workaround this issue.

Reported a follow-up for proper handling of this #574.

Changes

  • As above.

Fixes

  • As above.

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Copy link

changeset-bot bot commented Nov 23, 2023

🦋 Changeset detected

Latest commit: 1a5a238

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@monokle/synchronizer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@f1ames f1ames merged commit e26ed54 into main Nov 23, 2023
2 checks passed
@f1ames f1ames deleted the f1ames/fix/origin-conflict-workaround branch November 23, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants