Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve project matching logic #575

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Improve project matching logic #575

merged 2 commits into from
Nov 23, 2023

Conversation

f1ames
Copy link
Contributor

@f1ames f1ames commented Nov 23, 2023

This PR fixes #487 and fixes https://github.com/kubeshop/monokle-saas/issues/2219.

Changes

  • None.

Fixes

  • Added provide check into matching logic. Adjusted how provider is extracted from local git repo so that it matches providers we have in the API.
  • Removed prChecks flag check from matching logic.

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

By taking into account provider and ignoring 'prChecks' flag.
Copy link

changeset-bot bot commented Nov 23, 2023

🦋 Changeset detected

Latest commit: 25b86ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@monokle/synchronizer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@f1ames f1ames requested a review from WitoDelnat November 23, 2023 15:00
@f1ames f1ames merged commit 0380841 into main Nov 23, 2023
2 checks passed
@f1ames f1ames deleted the f1ames/fix/project-matching branch November 23, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Synchronizer should check git provider too when fetching data
2 participants