chore: Cleanup and fixes #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgeepc
reviewed
Sep 13, 2024
collector.config.yaml
Outdated
| @@ -11,11 +11,24 @@ receivers: | |||
| processors: | |||
| batch: | |||
|
|
|||
| tail_sampling: | |||
There was a problem hiding this comment.
Shouldn't we use the filter approach instead?
There was a problem hiding this comment.
I think the trace state policy is fine but maybe @mathnogueira has a different opinion
There was a problem hiding this comment.
the filter preprocessor is faster and doesn't require as much memory as this one. I mean, it's ok to use this here, but the filter would be better.
There was a problem hiding this comment.
Just changed it to use filter instead, seems to be working correctly!
| jaeger: | ||
| endpoint: ${JAEGER_ENDPOINT} | ||
| otlp: | ||
| endpoint: jaeger:4317 |
There was a problem hiding this comment.
Do we want to hardcode this?
There was a problem hiding this comment.
Yeah its all dockerized
mathnogueira
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a bunch of cleanup changes to make it easier to test, including upgrading the OTEL dependencies
Changes
Fixes
Checklist