fix(cli): reuse port listener on configurator #4054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
xoscar
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way the configurator chooses an open port to listen for OAuth callback. Previously, we got a free port by opening a
TCPListeneron port 0, which makes the OS return a port. We then closed the listener and use the port.The problem is that, some times, at least on MacOS, we can get
port already in useby the time we want to start the actual listener.This PR changes the flow, so instead of closing the port, we keep it open, and we pass it to the http server that handles the OAuth listener.
Changes
Fixes
Checklist
Loom video
Add your loom video here if your work can be visualized