-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce telemetry #33
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1ames
force-pushed
the
f1ames/fix/28-error-improvements
branch
from
August 21, 2023 14:50
012a58a
to
86141fb
Compare
f1ames
force-pushed
the
f1ames/feat/24-telemetry
branch
2 times, most recently
from
August 21, 2023 15:07
4fa3f8f
to
6e052e7
Compare
devcatalin
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f1ames
force-pushed
the
f1ames/fix/28-error-improvements
branch
from
August 22, 2023 10:22
a15285e
to
9bf5849
Compare
f1ames
force-pushed
the
f1ames/feat/24-telemetry
branch
from
August 22, 2023 10:28
6e052e7
to
2db8d5e
Compare
I rechecked if we can send telemetry events differently, so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #24.
Based on #31 and should be merged after it.
Changes
enableTelemetry
config option (true
by default).machineId
provided by VSC env.sessionId
. This can be used to group all events from single session (new session is when VSC instance is started/restarted).vscode-monokle/src/utils/telemetry.ts
Lines 69 to 97 in 02dc37e
Fixes
Checklist