Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated sidebar and prod dockerfile #225

Merged
merged 11 commits into from
Oct 23, 2024
Merged

updated sidebar and prod dockerfile #225

merged 11 commits into from
Oct 23, 2024

Conversation

uma-kt
Copy link
Contributor

@uma-kt uma-kt commented Oct 23, 2024

No description provided.

veenamj-avesha
veenamj-avesha approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@veenamj-avesha veenamj-avesha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

veenamj-avesha
veenamj-avesha requested changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@veenamj-avesha veenamj-avesha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Uma, I had asked you to rephrase the replica access method topics like Once changing to After and other things.

@uma-kt
Copy link
Contributor Author

uma-kt commented Oct 23, 2024

@Uma, I had asked you to rephrase the replica access method topics like Once changing to After and other things.

done

@veenamj-avesha
Copy link
Contributor

@Uma, I had asked you to rephrase the replica access method topics like Once changing to After and other things.

done

@uma-kt - there are some more pending items that I've added on your Slack DM. Can you also address them?

@uma-kt uma-kt merged commit e622cb8 into master Oct 23, 2024
6 of 8 checks passed
@uma-kt uma-kt deleted the AM-14456b branch October 23, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veenamj-avesha veenamj-avesha veenamj-avesha approved these changes

@eric978 eric978 Awaiting requested review from eric978 eric978 is a code owner

@narmidm narmidm Awaiting requested review from narmidm narmidm is a code owner

@priyank-upadhyay priyank-upadhyay Awaiting requested review from priyank-upadhyay priyank-upadhyay is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uma-kt @veenamj-avesha