Merge pull request #28 from MikeSpreitzer/more-args

✨ Add Helm chart parameters for QPS, burst, metrics, pprof
kubestellar · May 31, 2024 · 56b7b02 · 56b7b02
2 parents fa8ec3d + b68e84e
commit 56b7b02
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/chart/templates/controller.yaml b/chart/templates/controller.yaml
@@ -153,9 +153,15 @@ spec:
           image: OTP_IMAGE_PLACEHOLDER
           imagePullPolicy: IfNotPresent
           args:
+          - --metrics-bind-addr={{.Values.metrics_bind_addr}}
+          - --pprof-bind-addr={{.Values.pprof_bind_addr}}
           - --transport-kubeconfig=/mnt/shared/transport-kubeconfig
+          - --transport-qps={{.Values.transport_qps}}
+          - --transport-burst={{.Values.transport_burst}}
           - --wds-kubeconfig=/mnt/shared/wds-kubeconfig
           - --wds-name={{.Values.wds_cp_name}}
+          - --wds-qps={{.Values.wds_qps}}
+          - --wds-burst={{.Values.wds_burst}}
           - -v={{.Values.verbosity | default 4}}
           volumeMounts:
           - name: shared-volume

diff --git a/chart/values.yaml b/chart/values.yaml
@@ -19,4 +19,18 @@ transport_cp_name: ""
 wds_cp_name: wds1
 
 # Set the controller verbosity
-verbosity: 4
+verbosity: 4
+
+# [host]:port at which to listen for HTTP GET /metrics
+metrics_bind_addr: ":8090"
+
+# [host]:port at which to listen for HTTP GET /debug/pprof
+pprof_bind_addr: ":8092"
+
+# QPS and burst for accessing the ITS
+transport_qps: 5
+transport_burst: 10
+
+# QPS and burst for accessing the WDS
+wds_qps: 5
+qds_burst: 10