Avoid running more than one migration concurrently #1454
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1454 +/- ##
==========================================
- Coverage 36.81% 36.51% -0.31%
==========================================
Files 158 156 -2
Lines 2548 2528 -20
Branches 599 605 +6
==========================================
- Hits 938 923 -15
+ Misses 1428 1420 -8
- Partials 182 185 +3 ☔ View full report in Codecov by Sentry. |
| const buttonStartLabel = canReStart ? t('Restart migration') : t('Start migration'); | ||
|
|
||
| const [isStartItemEnabled, setIStartItemEnabled] = useState(canStart); |
| <DropdownItem | ||
| value={1} | ||
| key="start" | ||
| isDisabled={!canStart || !isStartItemEnabled} |
There was a problem hiding this comment.
why also !canStart? u check it on the effect
There was a problem hiding this comment.
This was added to avoid as much as possible the following scenario:
- Clicking on the "start migration" button (or any other way of starting the plan not via the dropdown) => plan is marked as running
- Clicking on the dropdown's 'start' option (since It takes few secs for the effect to re-render, button is not disabled yet).
Without this fix:
Screencast from 2025-02-12 11-36-51.webm
With this fix:
Screencast from 2025-02-12 11-40-14.webm
Reference: https://issues.redhat.com/browse/MTV-1901 Avoid running a migration (start/restart) if a migraiton is already running by disabling/hiding buttons and avoiding adding the migration CR. This will cover cases in which rendering takes few seconds when you use the start/restart action item and then the start/restart button at once. Signed-off-by: Sharon Gratch <[email protected]>
sgratch
force-pushed
the
avoid-running-concurrent-migrations
branch
from
a892663 to
49f5760
Compare
|
Reference: https://issues.redhat.com/browse/MTV-1901
📝 Description
Avoid running a migration (start/restart) if a migration is already running by disabling/hiding relevant buttons (in page header, actions menu and plan details status page).
Also avoid adding the migration CR to cover cases in which rendering takes few seconds when you use the start/restart action item and then the start/restart button at once.
🎥 Demo
Before
Screencast.from.2025-02-05.12-10-40.webm
After
Screencast.from.2025-02-05.12-06-55.webm