-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace VDDK image hint sections with rephrased warning alert sections #1459
Replace VDDK image hint sections with rephrased warning alert sections #1459
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1459 +/- ##
==========================================
- Coverage 36.81% 36.51% -0.31%
==========================================
Files 158 156 -2
Lines 2548 2528 -20
Branches 599 604 +5
==========================================
- Hits 938 923 -15
- Misses 1428 1600 +172
+ Partials 182 5 -177 ☔ View full report in Codecov by Sentry. |
@RichardHoch - please can you review the wording in this as well |
@sgratch This is the current full warning message in the documentation: It is strongly recommended to create a VMware Virtual Disk Development Kit (VDDK) image in a secure registry that is accessible to all clusters. A VDDK image accelerates migration and reduces the risk of a plan failing. If you are not using VDDK and a plan fails, then retry with VDDK installed. For more information, see xref:../master.adoc#creating-vddk-image_vmware[Creating a VDDK image]. Suggestions: Tooltip: 2nd paragraph, change to "To accelerate migration and reduce the risk of a plan failing,..." Window: Warning: "It is strongly recommended to use a VDDK image. Not using a VDDK image could result in significantly lower migration speeds or a plan failing. For more information, see xref:../master.adoc#creating-vddk-image_vmware[Creating a VDDK image]." (not sure if you format a link differently...) Text below text box: "The VDDK image is empty. It is strongly recommended to provide an image using the following format: ... " |
Reference: https://issues.redhat.com/browse/MTV-1783 Replace VDDK image hint sections with warning alert sections and rephrased the text to emphasize the importance of setting VDDK image value from performace reasons. Trying to be aligned with doc https://issues.redhat.com/browse/MTV-1782. Signed-off-by: Sharon Gratch <[email protected]>
50ecf28
to
b8f03ac
Compare
|
@RichardHoch Updated the text and screenshots accordingly. |
@sgratch You're the best! |
Reference: https://issues.redhat.com/browse/MTV-1783
📝 Description
Replace VDDK image hint sections with warning alert sections and rephrased the text to emphasize the importance of setting VDDK image value from performace reasons.
Trying to be aligned with doc https://issues.redhat.com/browse/MTV-1782.
🎥 Demo
Before
After
📝 CC://
@RichardHoch @anarnold97