Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MTV-1794] Add warning when specifying IP for a secure provider #1475

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented Feb 12, 2025

📝 Links

https://issues.redhat.com/browse/MTV-1794

📝 Description

Although "warning" messages were asked for, since with vcenter providers, having a certificate with a FQDN not matching the one offered in the URL input or the URL input not using a FQDN would lead to a failed provider connection and therefore an un-usable provider, error messages were instead used here.

Not only to identify URLs with IP addresses as asked for in the JIRA, but also to abide by the messaging outlined in the documentation for vcenter providers here, which states If a certificate for FQDN is specified, the value of this field needs to match the FQDN in the certificate..

In order to verify the certificate domain name, an already installed peer-dependency, node-forge, was leveraged here (and added as an explicit dependency).

🎥 Demo

Screen.Recording.2025-02-12.at.2.07.08.PM.mov

📝 CC://

@wolfeallison

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 29.72973% with 26 lines in your changes missing coverage. Please review.

Project coverage is 36.35%. Comparing base (13484d0) to head (da8b7bb).
Report is 248 commits behind head on main.

Files with missing lines Patch % Lines
.../validators/provider/vsphere/validateVCenterURL.ts 23.07% 20 Missing ⚠️
.../validators/provider/providerAndSecretValidator.ts 0.00% 2 Missing ⚠️
...ators/provider/vsphere/vsphereProviderValidator.ts 50.00% 2 Missing ⚠️
...n/src/modules/Providers/utils/validators/common.ts 66.66% 1 Missing ⚠️
...ers/utils/validators/provider/providerValidator.ts 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1475      +/-   ##
==========================================
- Coverage   36.81%   36.35%   -0.46%     
==========================================
  Files         158      156       -2     
  Lines        2548     2558      +10     
  Branches      599      595       -4     
==========================================
- Hits          938      930       -8     
- Misses       1428     1623     +195     
+ Partials      182        5     -177     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpuzz0 jpuzz0 added bug Categorizes issue or PR as related to a bug. enhancement Categorizes issue or PR as related to a new feature. labels Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug. enhancement Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants