Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MTV-1788] Failed to create OSP provider with authentication type - token and username #1478

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented Feb 14, 2025

📝 Links

https://issues.redhat.com/browse/MTV-1788

📝 Description

The incorrect Field ID was being used for the "Username" field, resulting in the wrong set of fields to validate (since these are conditionally set based on the "authentication type" radio selection).

The correct Field ID being used solved the problem, but to help prevent this from happening in the future, an enum was created as a source of truth for those Field IDs used across OpenStack provider create form sections.

We could also do this for other Provider forms that are not OpenStack, but this would be out of scope for this bug, and ideally done as a tech debt follow-up if wanted.

🎥 Demo

Before:
https://github.com/user-attachments/assets/2a6caac2-826f-4600-aa0a-a85731381563

After:
https://github.com/user-attachments/assets/709872d7-3a2a-4933-b55b-3299d65c6514

@jpuzz0 jpuzz0 added the bug Categorizes issue or PR as related to a bug. label Feb 14, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.51%. Comparing base (13484d0) to head (9045dc7).
Report is 250 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1478      +/-   ##
==========================================
- Coverage   36.81%   36.51%   -0.31%     
==========================================
  Files         158      156       -2     
  Lines        2548     2528      -20     
  Branches      599      605       +6     
==========================================
- Hits          938      923      -15     
- Misses       1428     1600     +172     
+ Partials      182        5     -177     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants