Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCP has ID no need to manually add it #613

Merged
merged 1 commit into from
Jul 26, 2023
Merged

OCP has ID no need to manually add it #613

merged 1 commit into from
Jul 26, 2023

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Jul 26, 2023

Issue:
before kubev2v/forklift#460 we needed to manually add id to ocp objects, it's redundant now.

Fix:
remove the manually added id

@yaacov yaacov added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 26, 2023
@yaacov yaacov added this to the 2.5.0 milestone Jul 26, 2023
@yaacov
Copy link
Member Author

yaacov commented Jul 26, 2023

cc:// @bennyz

@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yaacov yaacov merged commit 6b85835 into kubev2v:main Jul 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjd78 sjd78 Awaiting requested review from sjd78

@sgratch sgratch Awaiting requested review from sgratch

@rszwajko rszwajko Awaiting requested review from rszwajko

Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
1 participant
@yaacov